From 92f9a172d1976263e5aa5cf94c0b0a15e86f1215 Mon Sep 17 00:00:00 2001 From: Potatoboy9999 <51728317+PotatoPresident@users.noreply.github.com> Date: Tue, 14 Jun 2022 12:09:37 -0700 Subject: [PATCH 1/6] Improve performance --- build.gradle | 12 ++++- gradle.properties | 8 +-- .../LedgerDatabaseExtension.kt | 50 +++++++++++++++++++ .../ledger/databases/DatabaseExtensionSpec.kt | 4 +- 4 files changed, 66 insertions(+), 8 deletions(-) create mode 100644 src/main/kotlin/net.quiltservertools.ledger.databases/LedgerDatabaseExtension.kt diff --git a/build.gradle b/build.gradle index 5f2ceff..e0c3620 100644 --- a/build.gradle +++ b/build.gradle @@ -34,10 +34,12 @@ dependencies { modImplementation "net.fabricmc.fabric-api:fabric-api:${project.fabric_version}" // Yes this has to be capitalised - modImplementation "com.github.quiltservertools:ledger:1.2.0" + modImplementation "com.github.quiltservertools:Ledger:1.2.5" modImplementation "net.fabricmc:fabric-language-kotlin:1.7.0+kotlin.1.6.0" + implementation(include("com.zaxxer:HikariCP:5.0.1")) + // H2 implementation(include("com.h2database:h2:1.4.200")) @@ -79,7 +81,13 @@ jar { publishing { publications { mavenJava(MavenPublication) { - from(components["java"]) + // add all the jars that should be included when publishing to maven + artifact(remapJar) { + builtBy remapJar + } + artifact(sourcesJar) { + builtBy remapSourcesJar + } } } diff --git a/gradle.properties b/gradle.properties index 185a204..5c810ed 100644 --- a/gradle.properties +++ b/gradle.properties @@ -3,12 +3,12 @@ org.gradle.jvmargs=-Xmx1G # Fabric Properties # check these on https://fabricmc.net/versions.html - minecraft_version=1.18.1 - yarn_mappings=1.18.1+build.2 - loader_version=0.12.11 + minecraft_version=1.18.2 + yarn_mappings=1.18.2+build.3 + loader_version=0.12.5 # Mod Properties - mod_version = 1.1.1 + mod_version = 1.0.2 maven_group = net.quiltservertools archives_base_name = ledger-databases diff --git a/src/main/kotlin/net.quiltservertools.ledger.databases/LedgerDatabaseExtension.kt b/src/main/kotlin/net.quiltservertools.ledger.databases/LedgerDatabaseExtension.kt new file mode 100644 index 0000000..b6dc1f5 --- /dev/null +++ b/src/main/kotlin/net.quiltservertools.ledger.databases/LedgerDatabaseExtension.kt @@ -0,0 +1,50 @@ +package net.quiltservertools.ledger.databases + +import com.github.quiltservertools.ledger.Ledger +import com.github.quiltservertools.ledger.api.DatabaseExtension +import com.github.quiltservertools.libs.com.uchuhimo.konf.ConfigSpec +import com.zaxxer.hikari.HikariConfig +import com.zaxxer.hikari.HikariDataSource +import net.minecraft.util.Identifier +import org.h2.jdbcx.JdbcDataSource +import org.sqlite.SQLiteDataSource +import java.nio.file.Path +import javax.sql.DataSource +import kotlin.io.path.pathString + +class LedgerDatabaseExtension : DatabaseExtension { + override fun getConfigSpecs(): List = listOf(DatabaseExtensionSpec) + + override fun getDataSource(fileLocation: Path): DataSource { + return when (Ledger.config[DatabaseExtensionSpec.database]) { + Databases.SQLITE -> SQLiteDataSource().apply { + url = "jdbc:sqlite:${fileLocation.resolve("ledger.sqlite").pathString}" + } + + Databases.H2 -> JdbcDataSource().apply { + setURL("jdbc:h2:${fileLocation.resolve("ledger.h2").pathString};MODE=MySQL") + } + + Databases.MYSQL -> HikariDataSource(HikariConfig().apply { + jdbcUrl = "jdbc:mysql://${Ledger.config[DatabaseExtensionSpec.url]}?rewriteBatchedStatements=true" + username = Ledger.config[DatabaseExtensionSpec.userName] + password = Ledger.config[DatabaseExtensionSpec.password] + maximumPoolSize = Ledger.config[DatabaseExtensionSpec.maxPoolSize] + }) + + Databases.POSTGRESQL -> HikariDataSource(HikariConfig().apply { + jdbcUrl = "jdbc:postgresql://${Ledger.config[DatabaseExtensionSpec.url]}?rewriteBatchedStatements=true" + username = Ledger.config[DatabaseExtensionSpec.userName] + password = Ledger.config[DatabaseExtensionSpec.password] + maximumPoolSize = Ledger.config[DatabaseExtensionSpec.maxPoolSize] + }) + } + } + + override fun getIdentifier(): Identifier = when (Ledger.config[DatabaseExtensionSpec.database]) { + Databases.MYSQL -> Ledger.identifier("mysql_extension") + Databases.H2 -> Ledger.identifier("h2_extension") + Databases.POSTGRESQL -> Ledger.identifier("postgresql_extension") + else -> Ledger.identifier(Ledger.DEFAULT_DATABASE) + } +} diff --git a/src/main/kotlin/net/quiltservertools/ledger/databases/DatabaseExtensionSpec.kt b/src/main/kotlin/net/quiltservertools/ledger/databases/DatabaseExtensionSpec.kt index eb654dd..ead27c0 100644 --- a/src/main/kotlin/net/quiltservertools/ledger/databases/DatabaseExtensionSpec.kt +++ b/src/main/kotlin/net/quiltservertools/ledger/databases/DatabaseExtensionSpec.kt @@ -7,5 +7,5 @@ object DatabaseExtensionSpec : ConfigSpec("database_extensions") { val userName by optional("root", "username") val password by optional("", "password") val url by optional("localhost", "url") - val properties by optional(listOf(), "properties") -} + val maxPoolSize by optional(10, "maxPoolSize") +} \ No newline at end of file From 8b925fabf9724a21edca96796df9aa6ccef366f2 Mon Sep 17 00:00:00 2001 From: Potatoboy9999 <51728317+PotatoPresident@users.noreply.github.com> Date: Thu, 29 Jun 2023 15:30:11 -0700 Subject: [PATCH 2/6] Update things --- build.gradle | 10 +- gradle.properties | 10 +- gradle/wrapper/gradle-wrapper.properties | 2 +- gradlew | 269 ++++++++++++++--------- src/main/resources/fabric.mod.json | 7 +- 5 files changed, 175 insertions(+), 123 deletions(-) diff --git a/build.gradle b/build.gradle index e0c3620..941953e 100644 --- a/build.gradle +++ b/build.gradle @@ -1,7 +1,7 @@ plugins { - id 'fabric-loom' version '0.10-SNAPSHOT' + id 'fabric-loom' version '1.2.+' id 'maven-publish' - id 'org.jetbrains.kotlin.jvm' version "1.6.0" + id 'org.jetbrains.kotlin.jvm' version "1.8.22" } sourceCompatibility = JavaVersion.VERSION_17 @@ -34,11 +34,11 @@ dependencies { modImplementation "net.fabricmc.fabric-api:fabric-api:${project.fabric_version}" // Yes this has to be capitalised - modImplementation "com.github.quiltservertools:Ledger:1.2.5" + modImplementation "com.github.quiltservertools:Ledger:1.3.0" - modImplementation "net.fabricmc:fabric-language-kotlin:1.7.0+kotlin.1.6.0" + modImplementation "net.fabricmc:fabric-language-kotlin:1.9.4+kotlin.1.8.21" - implementation(include("com.zaxxer:HikariCP:5.0.1")) + implementation("com.zaxxer:HikariCP:5.0.1") // H2 implementation(include("com.h2database:h2:1.4.200")) diff --git a/gradle.properties b/gradle.properties index 5c810ed..bc3cb9a 100644 --- a/gradle.properties +++ b/gradle.properties @@ -3,14 +3,14 @@ org.gradle.jvmargs=-Xmx1G # Fabric Properties # check these on https://fabricmc.net/versions.html - minecraft_version=1.18.2 - yarn_mappings=1.18.2+build.3 - loader_version=0.12.5 + minecraft_version=1.19 + yarn_mappings=1.19+build.4 + loader_version=0.14.8 # Mod Properties - mod_version = 1.0.2 + mod_version = 1.2.0 maven_group = net.quiltservertools archives_base_name = ledger-databases # Dependencies - fabric_version=0.43.1+1.18 + fabric_version=0.58.0+1.19 diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index e750102..fae0804 100644 --- a/gradle/wrapper/gradle-wrapper.properties +++ b/gradle/wrapper/gradle-wrapper.properties @@ -1,5 +1,5 @@ distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists -distributionUrl=https\://services.gradle.org/distributions/gradle-7.3-bin.zip +distributionUrl=https\://services.gradle.org/distributions/gradle-8.1.1-bin.zip zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists diff --git a/gradlew b/gradlew index 744e882..c53aefa 100644 --- a/gradlew +++ b/gradlew @@ -1,7 +1,7 @@ -#!/usr/bin/env sh +#!/bin/sh # -# Copyright 2015 the original author or authors. +# Copyright © 2015-2021 the original authors. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. @@ -17,67 +17,101 @@ # ############################################################################## -## -## Gradle start up script for UN*X -## +# +# Gradle start up script for POSIX generated by Gradle. +# +# Important for running: +# +# (1) You need a POSIX-compliant shell to run this script. If your /bin/sh is +# noncompliant, but you have some other compliant shell such as ksh or +# bash, then to run this script, type that shell name before the whole +# command line, like: +# +# ksh Gradle +# +# Busybox and similar reduced shells will NOT work, because this script +# requires all of these POSIX shell features: +# * functions; +# * expansions «$var», «${var}», «${var:-default}», «${var+SET}», +# «${var#prefix}», «${var%suffix}», and «$( cmd )»; +# * compound commands having a testable exit status, especially «case»; +# * various built-in commands including «command», «set», and «ulimit». +# +# Important for patching: +# +# (2) This script targets any POSIX shell, so it avoids extensions provided +# by Bash, Ksh, etc; in particular arrays are avoided. +# +# The "traditional" practice of packing multiple parameters into a +# space-separated string is a well documented source of bugs and security +# problems, so this is (mostly) avoided, by progressively accumulating +# options in "$@", and eventually passing that to Java. +# +# Where the inherited environment variables (DEFAULT_JVM_OPTS, JAVA_OPTS, +# and GRADLE_OPTS) rely on word-splitting, this is performed explicitly; +# see the in-line comments for details. +# +# There are tweaks for specific operating systems such as AIX, CygWin, +# Darwin, MinGW, and NonStop. +# +# (3) This script is generated from the Groovy template +# https://github.com/gradle/gradle/blob/master/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt +# within the Gradle project. +# +# You can find Gradle at https://github.com/gradle/gradle/. +# ############################################################################## # Attempt to set APP_HOME + # Resolve links: $0 may be a link -PRG="$0" -# Need this for relative symlinks. -while [ -h "$PRG" ] ; do - ls=`ls -ld "$PRG"` - link=`expr "$ls" : '.*-> \(.*\)$'` - if expr "$link" : '/.*' > /dev/null; then - PRG="$link" - else - PRG=`dirname "$PRG"`"/$link" - fi +app_path=$0 + +# Need this for daisy-chained symlinks. +while + APP_HOME=${app_path%"${app_path##*/}"} # leaves a trailing /; empty if no leading path + [ -h "$app_path" ] +do + ls=$( ls -ld "$app_path" ) + link=${ls#*' -> '} + case $link in #( + /*) app_path=$link ;; #( + *) app_path=$APP_HOME$link ;; + esac done -SAVED="`pwd`" -cd "`dirname \"$PRG\"`/" >/dev/null -APP_HOME="`pwd -P`" -cd "$SAVED" >/dev/null + +APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit APP_NAME="Gradle" -APP_BASE_NAME=`basename "$0"` +APP_BASE_NAME=${0##*/} # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' # Use the maximum available, or set MAX_FD != -1 to use that value. -MAX_FD="maximum" +MAX_FD=maximum warn () { echo "$*" -} +} >&2 die () { echo echo "$*" echo exit 1 -} +} >&2 # OS specific support (must be 'true' or 'false'). cygwin=false msys=false darwin=false nonstop=false -case "`uname`" in - CYGWIN* ) - cygwin=true - ;; - Darwin* ) - darwin=true - ;; - MSYS* | MINGW* ) - msys=true - ;; - NONSTOP* ) - nonstop=true - ;; +case "$( uname )" in #( + CYGWIN* ) cygwin=true ;; #( + Darwin* ) darwin=true ;; #( + MSYS* | MINGW* ) msys=true ;; #( + NONSTOP* ) nonstop=true ;; esac CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar @@ -87,9 +121,9 @@ CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar if [ -n "$JAVA_HOME" ] ; then if [ -x "$JAVA_HOME/jre/sh/java" ] ; then # IBM's JDK on AIX uses strange locations for the executables - JAVACMD="$JAVA_HOME/jre/sh/java" + JAVACMD=$JAVA_HOME/jre/sh/java else - JAVACMD="$JAVA_HOME/bin/java" + JAVACMD=$JAVA_HOME/bin/java fi if [ ! -x "$JAVACMD" ] ; then die "ERROR: JAVA_HOME is set to an invalid directory: $JAVA_HOME @@ -98,7 +132,7 @@ Please set the JAVA_HOME variable in your environment to match the location of your Java installation." fi else - JAVACMD="java" + JAVACMD=java which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. Please set the JAVA_HOME variable in your environment to match the @@ -106,80 +140,95 @@ location of your Java installation." fi # Increase the maximum file descriptors if we can. -if [ "$cygwin" = "false" -a "$darwin" = "false" -a "$nonstop" = "false" ] ; then - MAX_FD_LIMIT=`ulimit -H -n` - if [ $? -eq 0 ] ; then - if [ "$MAX_FD" = "maximum" -o "$MAX_FD" = "max" ] ; then - MAX_FD="$MAX_FD_LIMIT" - fi - ulimit -n $MAX_FD - if [ $? -ne 0 ] ; then - warn "Could not set maximum file descriptor limit: $MAX_FD" - fi - else - warn "Could not query maximum file descriptor limit: $MAX_FD_LIMIT" - fi -fi - -# For Darwin, add options to specify how the application appears in the dock -if $darwin; then - GRADLE_OPTS="$GRADLE_OPTS \"-Xdock:name=$APP_NAME\" \"-Xdock:icon=$APP_HOME/media/gradle.icns\"" -fi - -# For Cygwin or MSYS, switch paths to Windows format before running java -if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then - APP_HOME=`cygpath --path --mixed "$APP_HOME"` - CLASSPATH=`cygpath --path --mixed "$CLASSPATH"` - - JAVACMD=`cygpath --unix "$JAVACMD"` - - # We build the pattern for arguments to be converted via cygpath - ROOTDIRSRAW=`find -L / -maxdepth 1 -mindepth 1 -type d 2>/dev/null` - SEP="" - for dir in $ROOTDIRSRAW ; do - ROOTDIRS="$ROOTDIRS$SEP$dir" - SEP="|" - done - OURCYGPATTERN="(^($ROOTDIRS))" - # Add a user-defined pattern to the cygpath arguments - if [ "$GRADLE_CYGPATTERN" != "" ] ; then - OURCYGPATTERN="$OURCYGPATTERN|($GRADLE_CYGPATTERN)" - fi - # Now convert the arguments - kludge to limit ourselves to /bin/sh - i=0 - for arg in "$@" ; do - CHECK=`echo "$arg"|egrep -c "$OURCYGPATTERN" -` - CHECK2=`echo "$arg"|egrep -c "^-"` ### Determine if an option - - if [ $CHECK -ne 0 ] && [ $CHECK2 -eq 0 ] ; then ### Added a condition - eval `echo args$i`=`cygpath --path --ignore --mixed "$arg"` - else - eval `echo args$i`="\"$arg\"" - fi - i=`expr $i + 1` - done - case $i in - 0) set -- ;; - 1) set -- "$args0" ;; - 2) set -- "$args0" "$args1" ;; - 3) set -- "$args0" "$args1" "$args2" ;; - 4) set -- "$args0" "$args1" "$args2" "$args3" ;; - 5) set -- "$args0" "$args1" "$args2" "$args3" "$args4" ;; - 6) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" ;; - 7) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" ;; - 8) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" ;; - 9) set -- "$args0" "$args1" "$args2" "$args3" "$args4" "$args5" "$args6" "$args7" "$args8" ;; +if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then + case $MAX_FD in #( + max*) + MAX_FD=$( ulimit -H -n ) || + warn "Could not query maximum file descriptor limit" + esac + case $MAX_FD in #( + '' | soft) :;; #( + *) + ulimit -n "$MAX_FD" || + warn "Could not set maximum file descriptor limit to $MAX_FD" esac fi -# Escape application args -save () { - for i do printf %s\\n "$i" | sed "s/'/'\\\\''/g;1s/^/'/;\$s/\$/' \\\\/" ; done - echo " " -} -APP_ARGS=`save "$@"` +# Collect all arguments for the java command, stacking in reverse order: +# * args from the command line +# * the main class name +# * -classpath +# * -D...appname settings +# * --module-path (only if needed) +# * DEFAULT_JVM_OPTS, JAVA_OPTS, and GRADLE_OPTS environment variables. -# Collect all arguments for the java command, following the shell quoting and substitution rules -eval set -- $DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS "\"-Dorg.gradle.appname=$APP_BASE_NAME\"" -classpath "\"$CLASSPATH\"" org.gradle.wrapper.GradleWrapperMain "$APP_ARGS" +# For Cygwin or MSYS, switch paths to Windows format before running java +if "$cygwin" || "$msys" ; then + APP_HOME=$( cygpath --path --mixed "$APP_HOME" ) + CLASSPATH=$( cygpath --path --mixed "$CLASSPATH" ) + + JAVACMD=$( cygpath --unix "$JAVACMD" ) + + # Now convert the arguments - kludge to limit ourselves to /bin/sh + for arg do + if + case $arg in #( + -*) false ;; # don't mess with options #( + /?*) t=${arg#/} t=/${t%%/*} # looks like a POSIX filepath + [ -e "$t" ] ;; #( + *) false ;; + esac + then + arg=$( cygpath --path --ignore --mixed "$arg" ) + fi + # Roll the args list around exactly as many times as the number of + # args, so each arg winds up back in the position where it started, but + # possibly modified. + # + # NB: a `for` loop captures its iteration list before it begins, so + # changing the positional parameters here affects neither the number of + # iterations, nor the values presented in `arg`. + shift # remove old arg + set -- "$@" "$arg" # push replacement arg + done +fi + +# Collect all arguments for the java command; +# * $DEFAULT_JVM_OPTS, $JAVA_OPTS, and $GRADLE_OPTS can contain fragments of +# shell script including quotes and variable substitutions, so put them in +# double quotes to make sure that they get re-expanded; and +# * put everything else in single quotes, so that it's not re-expanded. + +set -- \ + "-Dorg.gradle.appname=$APP_BASE_NAME" \ + -classpath "$CLASSPATH" \ + org.gradle.wrapper.GradleWrapperMain \ + "$@" + +# Use "xargs" to parse quoted args. +# +# With -n1 it outputs one arg per line, with the quotes and backslashes removed. +# +# In Bash we could simply go: +# +# readarray ARGS < <( xargs -n1 <<<"$var" ) && +# set -- "${ARGS[@]}" "$@" +# +# but POSIX shell has neither arrays nor command substitution, so instead we +# post-process each arg (as a line of input to sed) to backslash-escape any +# character that might be a shell metacharacter, then use eval to reverse +# that process (while maintaining the separation between arguments), and wrap +# the whole thing up as a single "set" statement. +# +# This will of course break if any of these variables contains a newline or +# an unmatched quote. +# + +eval "set -- $( + printf '%s\n' "$DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS" | + xargs -n1 | + sed ' s~[^-[:alnum:]+,./:=@_]~\\&~g; ' | + tr '\n' ' ' + )" '"$@"' exec "$JAVACMD" "$@" diff --git a/src/main/resources/fabric.mod.json b/src/main/resources/fabric.mod.json index e508653..4ce8b64 100644 --- a/src/main/resources/fabric.mod.json +++ b/src/main/resources/fabric.mod.json @@ -8,6 +8,10 @@ "authors": [ "yitzy299" ], + "contact": { + "homepage": "https://fabricmc.net/", + "sources": "https://github.com/FabricMC/fabric-example-mod" + }, "license": "LGPL-3.0", @@ -23,9 +27,8 @@ "depends": { "fabricloader": ">=0.12.5", "fabric": "*", - "minecraft": ">=1.18", "java": ">=16", - "ledger": ">=1.2.0", + "ledger": ">=1.3.0", "fabric-language-kotlin": "*" } } From 7bbc2ab8ab1818dc85f439f405fe4b5aab222782 Mon Sep 17 00:00:00 2001 From: Potatoboy9999 <51728317+PotatoPresident@users.noreply.github.com> Date: Tue, 9 Apr 2024 19:32:52 -0700 Subject: [PATCH 3/6] Redo things --- build.gradle | 11 ++-- .../LedgerDatabaseExtension.kt | 50 ------------------- .../ledger/databases/DatabaseExtensionSpec.kt | 8 +-- .../ledger/databases/Databases.kt | 11 ++-- .../databases/LedgerDatabaseExtension.kt | 13 ++--- .../ledger/databases/LedgerDatabases.kt | 8 ++- .../ledger/databases/databases/H2Database.kt | 17 ++++--- .../databases/databases/LedgerDatabase.kt | 6 +-- .../ledger/databases/databases/MySQL.kt | 39 ++++++++++----- .../ledger/databases/databases/PostgreSQL.kt | 27 +++++----- .../ledger/databases/databases/SQLite.kt | 12 ++--- 11 files changed, 88 insertions(+), 114 deletions(-) delete mode 100644 src/main/kotlin/net.quiltservertools.ledger.databases/LedgerDatabaseExtension.kt diff --git a/build.gradle b/build.gradle index 941953e..a6388ab 100644 --- a/build.gradle +++ b/build.gradle @@ -19,9 +19,6 @@ repositories { maven { url = "https://oss.sonatype.org/content/repositories/snapshots" } - maven { - url = "https://maven.bymartrixx.me/" - } } dependencies { @@ -34,20 +31,20 @@ dependencies { modImplementation "net.fabricmc.fabric-api:fabric-api:${project.fabric_version}" // Yes this has to be capitalised - modImplementation "com.github.quiltservertools:Ledger:1.3.0" + modImplementation "com.github.quiltservertools:Ledger:1.3.0+local" modImplementation "net.fabricmc:fabric-language-kotlin:1.9.4+kotlin.1.8.21" implementation("com.zaxxer:HikariCP:5.0.1") // H2 - implementation(include("com.h2database:h2:1.4.200")) + implementation(include("com.h2database:h2:2.2.224")) // MySQL - implementation(include('mysql:mysql-connector-java:8.0.19')) + implementation(include('mysql:mysql-connector-java:8.3.0')) // PostgreSQL - implementation(include("org.postgresql:postgresql:42.3.0")) + implementation(include("org.postgresql:postgresql:42.7.3")) } processResources { diff --git a/src/main/kotlin/net.quiltservertools.ledger.databases/LedgerDatabaseExtension.kt b/src/main/kotlin/net.quiltservertools.ledger.databases/LedgerDatabaseExtension.kt deleted file mode 100644 index b6dc1f5..0000000 --- a/src/main/kotlin/net.quiltservertools.ledger.databases/LedgerDatabaseExtension.kt +++ /dev/null @@ -1,50 +0,0 @@ -package net.quiltservertools.ledger.databases - -import com.github.quiltservertools.ledger.Ledger -import com.github.quiltservertools.ledger.api.DatabaseExtension -import com.github.quiltservertools.libs.com.uchuhimo.konf.ConfigSpec -import com.zaxxer.hikari.HikariConfig -import com.zaxxer.hikari.HikariDataSource -import net.minecraft.util.Identifier -import org.h2.jdbcx.JdbcDataSource -import org.sqlite.SQLiteDataSource -import java.nio.file.Path -import javax.sql.DataSource -import kotlin.io.path.pathString - -class LedgerDatabaseExtension : DatabaseExtension { - override fun getConfigSpecs(): List = listOf(DatabaseExtensionSpec) - - override fun getDataSource(fileLocation: Path): DataSource { - return when (Ledger.config[DatabaseExtensionSpec.database]) { - Databases.SQLITE -> SQLiteDataSource().apply { - url = "jdbc:sqlite:${fileLocation.resolve("ledger.sqlite").pathString}" - } - - Databases.H2 -> JdbcDataSource().apply { - setURL("jdbc:h2:${fileLocation.resolve("ledger.h2").pathString};MODE=MySQL") - } - - Databases.MYSQL -> HikariDataSource(HikariConfig().apply { - jdbcUrl = "jdbc:mysql://${Ledger.config[DatabaseExtensionSpec.url]}?rewriteBatchedStatements=true" - username = Ledger.config[DatabaseExtensionSpec.userName] - password = Ledger.config[DatabaseExtensionSpec.password] - maximumPoolSize = Ledger.config[DatabaseExtensionSpec.maxPoolSize] - }) - - Databases.POSTGRESQL -> HikariDataSource(HikariConfig().apply { - jdbcUrl = "jdbc:postgresql://${Ledger.config[DatabaseExtensionSpec.url]}?rewriteBatchedStatements=true" - username = Ledger.config[DatabaseExtensionSpec.userName] - password = Ledger.config[DatabaseExtensionSpec.password] - maximumPoolSize = Ledger.config[DatabaseExtensionSpec.maxPoolSize] - }) - } - } - - override fun getIdentifier(): Identifier = when (Ledger.config[DatabaseExtensionSpec.database]) { - Databases.MYSQL -> Ledger.identifier("mysql_extension") - Databases.H2 -> Ledger.identifier("h2_extension") - Databases.POSTGRESQL -> Ledger.identifier("postgresql_extension") - else -> Ledger.identifier(Ledger.DEFAULT_DATABASE) - } -} diff --git a/src/main/kotlin/net/quiltservertools/ledger/databases/DatabaseExtensionSpec.kt b/src/main/kotlin/net/quiltservertools/ledger/databases/DatabaseExtensionSpec.kt index ead27c0..e38365b 100644 --- a/src/main/kotlin/net/quiltservertools/ledger/databases/DatabaseExtensionSpec.kt +++ b/src/main/kotlin/net/quiltservertools/ledger/databases/DatabaseExtensionSpec.kt @@ -1,11 +1,13 @@ package net.quiltservertools.ledger.databases -import com.github.quiltservertools.libs.com.uchuhimo.konf.ConfigSpec +import com.uchuhimo.konf.ConfigSpec object DatabaseExtensionSpec : ConfigSpec("database_extensions") { - val database by optional(Databases.SQLITE, "database") + val database by required("database") val userName by optional("root", "username") val password by optional("", "password") val url by optional("localhost", "url") + val properties by optional(mapOf(), "properties") val maxPoolSize by optional(10, "maxPoolSize") -} \ No newline at end of file + val connectionTimeout by optional(60000L, "connectionTimeout") +} diff --git a/src/main/kotlin/net/quiltservertools/ledger/databases/Databases.kt b/src/main/kotlin/net/quiltservertools/ledger/databases/Databases.kt index ee7fc19..ee83d2f 100644 --- a/src/main/kotlin/net/quiltservertools/ledger/databases/Databases.kt +++ b/src/main/kotlin/net/quiltservertools/ledger/databases/Databases.kt @@ -1,10 +1,15 @@ package net.quiltservertools.ledger.databases -import net.quiltservertools.ledger.databases.databases.* +import net.quiltservertools.ledger.databases.databases.H2Database +import net.quiltservertools.ledger.databases.databases.LedgerDatabase +import net.quiltservertools.ledger.databases.databases.MySQL +import net.quiltservertools.ledger.databases.databases.PostgreSQL +import net.quiltservertools.ledger.databases.databases.SQLite + enum class Databases(val database: LedgerDatabase) { - SQLITE(SQLite), MYSQL(MySQL), H2(H2Database), - POSTGRESQL(PostgreSQL) + POSTGRESQL(PostgreSQL), + SQLITE(SQLite) } \ No newline at end of file diff --git a/src/main/kotlin/net/quiltservertools/ledger/databases/LedgerDatabaseExtension.kt b/src/main/kotlin/net/quiltservertools/ledger/databases/LedgerDatabaseExtension.kt index 5994d73..0dce3d5 100644 --- a/src/main/kotlin/net/quiltservertools/ledger/databases/LedgerDatabaseExtension.kt +++ b/src/main/kotlin/net/quiltservertools/ledger/databases/LedgerDatabaseExtension.kt @@ -2,17 +2,18 @@ package net.quiltservertools.ledger.databases import com.github.quiltservertools.ledger.Ledger import com.github.quiltservertools.ledger.api.DatabaseExtension -import com.github.quiltservertools.libs.com.uchuhimo.konf.ConfigSpec -import net.minecraft.server.MinecraftServer +import com.uchuhimo.konf.ConfigSpec import net.minecraft.util.Identifier -import org.jetbrains.exposed.sql.Database +import java.nio.file.Path +import javax.sql.DataSource class LedgerDatabaseExtension : DatabaseExtension { override fun getConfigSpecs(): List = listOf(DatabaseExtensionSpec) - override fun getDatabase(server: MinecraftServer): Database { - return Ledger.config[DatabaseExtensionSpec.database].database.getDatabase(server) + override fun getDataSource(savePath: Path): DataSource { + return Ledger.config[DatabaseExtensionSpec.database].database.getDataSource(savePath) } - override fun getIdentifier(): Identifier = Ledger.config[DatabaseExtensionSpec.database].database.getDatabaseIdentifier() + override fun getIdentifier(): Identifier = + Ledger.config[DatabaseExtensionSpec.database].database.getDatabaseIdentifier() } diff --git a/src/main/kotlin/net/quiltservertools/ledger/databases/LedgerDatabases.kt b/src/main/kotlin/net/quiltservertools/ledger/databases/LedgerDatabases.kt index 088431d..1129d58 100644 --- a/src/main/kotlin/net/quiltservertools/ledger/databases/LedgerDatabases.kt +++ b/src/main/kotlin/net/quiltservertools/ledger/databases/LedgerDatabases.kt @@ -2,9 +2,15 @@ package net.quiltservertools.ledger.databases import com.github.quiltservertools.ledger.api.ExtensionManager import net.fabricmc.api.DedicatedServerModInitializer +import net.minecraft.util.Identifier + +const val MOD_ID = "ledger-databases" + +object LedgerDatabases : DedicatedServerModInitializer { -class LedgerDatabases : DedicatedServerModInitializer { override fun onInitializeServer() { ExtensionManager.registerExtension(LedgerDatabaseExtension()) } + + fun identifier(path: String) = Identifier(MOD_ID, path) } \ No newline at end of file diff --git a/src/main/kotlin/net/quiltservertools/ledger/databases/databases/H2Database.kt b/src/main/kotlin/net/quiltservertools/ledger/databases/databases/H2Database.kt index cdc6dce..b8a06d3 100644 --- a/src/main/kotlin/net/quiltservertools/ledger/databases/databases/H2Database.kt +++ b/src/main/kotlin/net/quiltservertools/ledger/databases/databases/H2Database.kt @@ -1,14 +1,15 @@ package net.quiltservertools.ledger.databases.databases -import com.github.quiltservertools.ledger.Ledger -import net.minecraft.server.MinecraftServer -import net.minecraft.util.WorldSavePath -import org.jetbrains.exposed.sql.Database +import net.quiltservertools.ledger.databases.LedgerDatabases +import org.h2.jdbcx.JdbcDataSource +import java.nio.file.Path +import javax.sql.DataSource +import kotlin.io.path.pathString object H2Database : LedgerDatabase { - override fun getDatabase(server: MinecraftServer) = Database.connect( - url = "jdbc:h2:${server.getSavePath(WorldSavePath.ROOT).resolve("ledger.h2").toFile()};MODE=MySQL" - ) + override fun getDataSource(savePath: Path): DataSource = JdbcDataSource().apply { + setURL("jdbc:h2:${savePath.pathString};MODE=MySQL") + } - override fun getDatabaseIdentifier() = Ledger.identifier("h2") + override fun getDatabaseIdentifier() = LedgerDatabases.identifier("h2") } diff --git a/src/main/kotlin/net/quiltservertools/ledger/databases/databases/LedgerDatabase.kt b/src/main/kotlin/net/quiltservertools/ledger/databases/databases/LedgerDatabase.kt index 54983ca..bfe6224 100644 --- a/src/main/kotlin/net/quiltservertools/ledger/databases/databases/LedgerDatabase.kt +++ b/src/main/kotlin/net/quiltservertools/ledger/databases/databases/LedgerDatabase.kt @@ -1,10 +1,10 @@ package net.quiltservertools.ledger.databases.databases -import net.minecraft.server.MinecraftServer import net.minecraft.util.Identifier -import org.jetbrains.exposed.sql.Database +import java.nio.file.Path +import javax.sql.DataSource interface LedgerDatabase { - fun getDatabase(server: MinecraftServer): Database + fun getDataSource(savePath: Path): DataSource fun getDatabaseIdentifier(): Identifier } \ No newline at end of file diff --git a/src/main/kotlin/net/quiltservertools/ledger/databases/databases/MySQL.kt b/src/main/kotlin/net/quiltservertools/ledger/databases/databases/MySQL.kt index 8604f6f..f362422 100644 --- a/src/main/kotlin/net/quiltservertools/ledger/databases/databases/MySQL.kt +++ b/src/main/kotlin/net/quiltservertools/ledger/databases/databases/MySQL.kt @@ -1,22 +1,35 @@ package net.quiltservertools.ledger.databases.databases import com.github.quiltservertools.ledger.Ledger -import net.minecraft.server.MinecraftServer +import com.zaxxer.hikari.HikariConfig +import com.zaxxer.hikari.HikariDataSource import net.quiltservertools.ledger.databases.DatabaseExtensionSpec -import org.jetbrains.exposed.sql.Database +import net.quiltservertools.ledger.databases.LedgerDatabases +import java.nio.file.Path +import javax.sql.DataSource object MySQL : LedgerDatabase { - override fun getDatabase(server: MinecraftServer): Database { - var url = "jdbc:mysql://${Ledger.config[DatabaseExtensionSpec.url]}?rewriteBatchedStatements=true" - for (arg in Ledger.config[DatabaseExtensionSpec.properties]) { - url = url.plus("&$arg") + override fun getDataSource(savePath: Path): DataSource = HikariDataSource(HikariConfig().apply { + jdbcUrl = "jdbc:mysql://${Ledger.config[DatabaseExtensionSpec.url]}" + username = Ledger.config[DatabaseExtensionSpec.userName] + password = Ledger.config[DatabaseExtensionSpec.password] + maximumPoolSize = Ledger.config[DatabaseExtensionSpec.maxPoolSize] + connectionTimeout = Ledger.config[DatabaseExtensionSpec.connectionTimeout] + addDataSourceProperty("rewriteBatchedStatements", "true") + addDataSourceProperty("cachePrepStmts", true) + addDataSourceProperty("prepStmtCacheSize", 250) + addDataSourceProperty("prepStmtCacheSqlLimit", 2048) + addDataSourceProperty("useServerPrepStmts", true) + addDataSourceProperty("cacheCallableStmts", true) + addDataSourceProperty("cacheResultSetMetadata", true) + addDataSourceProperty("cacheServerConfiguration", true) + addDataSourceProperty("useLocalSessionState", true) + addDataSourceProperty("elideSetAutoCommits", true) + addDataSourceProperty("alwaysSendSetIsolation", false) + for ((key, value) in Ledger.config[DatabaseExtensionSpec.properties]) { + addDataSourceProperty(key, value) } - return Database.connect( - url = url, - user = Ledger.config[DatabaseExtensionSpec.userName], - password = Ledger.config[DatabaseExtensionSpec.password] - ) - } + }) - override fun getDatabaseIdentifier() = Ledger.identifier("mysql") + override fun getDatabaseIdentifier() = LedgerDatabases.identifier("mysql") } diff --git a/src/main/kotlin/net/quiltservertools/ledger/databases/databases/PostgreSQL.kt b/src/main/kotlin/net/quiltservertools/ledger/databases/databases/PostgreSQL.kt index 7da024c..9628fe7 100644 --- a/src/main/kotlin/net/quiltservertools/ledger/databases/databases/PostgreSQL.kt +++ b/src/main/kotlin/net/quiltservertools/ledger/databases/databases/PostgreSQL.kt @@ -1,22 +1,23 @@ package net.quiltservertools.ledger.databases.databases import com.github.quiltservertools.ledger.Ledger -import net.minecraft.server.MinecraftServer +import com.zaxxer.hikari.HikariConfig +import com.zaxxer.hikari.HikariDataSource import net.quiltservertools.ledger.databases.DatabaseExtensionSpec -import org.jetbrains.exposed.sql.Database +import net.quiltservertools.ledger.databases.LedgerDatabases +import java.nio.file.Path +import javax.sql.DataSource object PostgreSQL : LedgerDatabase { - override fun getDatabase(server: MinecraftServer): Database { - var url = "jdbc:postgresql://${Ledger.config[DatabaseExtensionSpec.url]}?rewriteBatchedStatements=true" - for (arg in Ledger.config[DatabaseExtensionSpec.properties]) { - url = url.plus("&$arg") + override fun getDataSource(savePath: Path): DataSource = HikariDataSource(HikariConfig().apply { + jdbcUrl = "jdbc:postgresql://${Ledger.config[DatabaseExtensionSpec.url]}" + username = Ledger.config[DatabaseExtensionSpec.userName] + password = Ledger.config[DatabaseExtensionSpec.password] + maximumPoolSize = Ledger.config[DatabaseExtensionSpec.maxPoolSize] + for ((key, value) in Ledger.config[DatabaseExtensionSpec.properties]) { + addDataSourceProperty(key, value) } - return Database.connect( - url = url, - user = Ledger.config[DatabaseExtensionSpec.userName], - password = Ledger.config[DatabaseExtensionSpec.password] - ) - } + }) - override fun getDatabaseIdentifier() = Ledger.identifier("postgresql") + override fun getDatabaseIdentifier() = LedgerDatabases.identifier("postgresql") } diff --git a/src/main/kotlin/net/quiltservertools/ledger/databases/databases/SQLite.kt b/src/main/kotlin/net/quiltservertools/ledger/databases/databases/SQLite.kt index aa6fe9b..c740291 100644 --- a/src/main/kotlin/net/quiltservertools/ledger/databases/databases/SQLite.kt +++ b/src/main/kotlin/net/quiltservertools/ledger/databases/databases/SQLite.kt @@ -1,15 +1,13 @@ package net.quiltservertools.ledger.databases.databases import com.github.quiltservertools.ledger.Ledger -import net.minecraft.server.MinecraftServer -import net.minecraft.util.WorldSavePath -import org.jetbrains.exposed.sql.Database -import kotlin.io.path.pathString +import org.sqlite.SQLiteDataSource +import java.nio.file.Path object SQLite : LedgerDatabase { - override fun getDatabase(server: MinecraftServer) = Database.connect( - url = "jdbc:sqlite:${server.getSavePath(WorldSavePath.ROOT).resolve("ledger.sqlite").pathString}" - ) + override fun getDataSource(savePath: Path) = SQLiteDataSource().apply { + url = "jdbc:sqlite:$savePath" + } override fun getDatabaseIdentifier() = Ledger.identifier(Ledger.DEFAULT_DATABASE) } From c583e32baba63dbe761b65410cfe74cbae3acf65 Mon Sep 17 00:00:00 2001 From: Potatoboy9999 <51728317+PotatoPresident@users.noreply.github.com> Date: Tue, 9 Apr 2024 20:24:02 -0700 Subject: [PATCH 4/6] Fix runtime issues --- build.gradle | 7 ++----- gradle.properties | 2 +- src/main/resources/fabric.mod.json | 2 +- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/build.gradle b/build.gradle index a6388ab..6671a78 100644 --- a/build.gradle +++ b/build.gradle @@ -27,21 +27,18 @@ dependencies { mappings "net.fabricmc:yarn:${project.yarn_mappings}:v2" modImplementation "net.fabricmc:fabric-loader:${project.loader_version}" - // Fabric API. This is technically optional, but you probably want it anyway. - modImplementation "net.fabricmc.fabric-api:fabric-api:${project.fabric_version}" - // Yes this has to be capitalised modImplementation "com.github.quiltservertools:Ledger:1.3.0+local" modImplementation "net.fabricmc:fabric-language-kotlin:1.9.4+kotlin.1.8.21" - implementation("com.zaxxer:HikariCP:5.0.1") + implementation(include("com.zaxxer:HikariCP:5.0.1")) // H2 implementation(include("com.h2database:h2:2.2.224")) // MySQL - implementation(include('mysql:mysql-connector-java:8.3.0')) + implementation(include('com.mysql:mysql-connector-j:8.3.0')) // PostgreSQL implementation(include("org.postgresql:postgresql:42.7.3")) diff --git a/gradle.properties b/gradle.properties index bc3cb9a..bc70814 100644 --- a/gradle.properties +++ b/gradle.properties @@ -1,5 +1,5 @@ # Done to increase the memory available to gradle. -org.gradle.jvmargs=-Xmx1G +org.gradle.jvmargs=-Xmx2G # Fabric Properties # check these on https://fabricmc.net/versions.html diff --git a/src/main/resources/fabric.mod.json b/src/main/resources/fabric.mod.json index 4ce8b64..b01b8ea 100644 --- a/src/main/resources/fabric.mod.json +++ b/src/main/resources/fabric.mod.json @@ -19,7 +19,7 @@ "entrypoints": { "server": [ { - "value": "net.quiltservertools.ledger.databases.LedgerDatabases" + "value": "net.quiltservertools.ledger.databases.LedgerDatabases::INSTANCE" } ] }, From 9f1f12318dc9bd2eb45a4c0ff975e19fea8d68f3 Mon Sep 17 00:00:00 2001 From: Potatoboy9999 <51728317+PotatoPresident@users.noreply.github.com> Date: Wed, 10 Apr 2024 10:14:10 -0700 Subject: [PATCH 5/6] Minor fixes --- README.md | 11 +++++++++++ gradle.properties | 5 +---- .../ledger/databases/databases/MySQL.kt | 3 +++ .../ledger/databases/databases/PostgreSQL.kt | 1 + .../ledger/databases/databases/SQLite.kt | 3 ++- src/main/resources/fabric.mod.json | 4 ++-- 6 files changed, 20 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index 3cd3578..8bf46d4 100644 --- a/README.md +++ b/README.md @@ -28,6 +28,8 @@ url = "" username = "" password = "" properties = [] +maxPoolSize = 10 +connectionTimeout = 60000 ``` `url`: Must be URL of database with `/` appended. An example URL would be `localhost/ledger`. You can optionally add port information such as `localhost:3000/ledger` @@ -41,6 +43,15 @@ url = "" username = "" password = "" properties = [] +maxPoolSize = 10 +connectionTimeout = 60000 +``` + +## SQLite + +```toml +[database_extensions] +database = "SQLITE" ``` ## Connector properties diff --git a/gradle.properties b/gradle.properties index bc70814..f79bc17 100644 --- a/gradle.properties +++ b/gradle.properties @@ -10,7 +10,4 @@ org.gradle.jvmargs=-Xmx2G # Mod Properties mod_version = 1.2.0 maven_group = net.quiltservertools - archives_base_name = ledger-databases - -# Dependencies - fabric_version=0.58.0+1.19 + archives_base_name = ledger-databases \ No newline at end of file diff --git a/src/main/kotlin/net/quiltservertools/ledger/databases/databases/MySQL.kt b/src/main/kotlin/net/quiltservertools/ledger/databases/databases/MySQL.kt index f362422..684de79 100644 --- a/src/main/kotlin/net/quiltservertools/ledger/databases/databases/MySQL.kt +++ b/src/main/kotlin/net/quiltservertools/ledger/databases/databases/MySQL.kt @@ -26,6 +26,9 @@ object MySQL : LedgerDatabase { addDataSourceProperty("useLocalSessionState", true) addDataSourceProperty("elideSetAutoCommits", true) addDataSourceProperty("alwaysSendSetIsolation", false) + addDataSourceProperty("useJDBCCompliantTimezoneShift", true) + addDataSourceProperty("useLegacyDatetimeCode", false) + addDataSourceProperty("serverTimezone", "UTC") for ((key, value) in Ledger.config[DatabaseExtensionSpec.properties]) { addDataSourceProperty(key, value) } diff --git a/src/main/kotlin/net/quiltservertools/ledger/databases/databases/PostgreSQL.kt b/src/main/kotlin/net/quiltservertools/ledger/databases/databases/PostgreSQL.kt index 9628fe7..59d0ba7 100644 --- a/src/main/kotlin/net/quiltservertools/ledger/databases/databases/PostgreSQL.kt +++ b/src/main/kotlin/net/quiltservertools/ledger/databases/databases/PostgreSQL.kt @@ -14,6 +14,7 @@ object PostgreSQL : LedgerDatabase { username = Ledger.config[DatabaseExtensionSpec.userName] password = Ledger.config[DatabaseExtensionSpec.password] maximumPoolSize = Ledger.config[DatabaseExtensionSpec.maxPoolSize] + addDataSourceProperty("reWriteBatchedInserts", "true") for ((key, value) in Ledger.config[DatabaseExtensionSpec.properties]) { addDataSourceProperty(key, value) } diff --git a/src/main/kotlin/net/quiltservertools/ledger/databases/databases/SQLite.kt b/src/main/kotlin/net/quiltservertools/ledger/databases/databases/SQLite.kt index c740291..5458767 100644 --- a/src/main/kotlin/net/quiltservertools/ledger/databases/databases/SQLite.kt +++ b/src/main/kotlin/net/quiltservertools/ledger/databases/databases/SQLite.kt @@ -3,10 +3,11 @@ package net.quiltservertools.ledger.databases.databases import com.github.quiltservertools.ledger.Ledger import org.sqlite.SQLiteDataSource import java.nio.file.Path +import kotlin.io.path.pathString object SQLite : LedgerDatabase { override fun getDataSource(savePath: Path) = SQLiteDataSource().apply { - url = "jdbc:sqlite:$savePath" + url = "jdbc:sqlite:${savePath.pathString}" } override fun getDatabaseIdentifier() = Ledger.identifier(Ledger.DEFAULT_DATABASE) diff --git a/src/main/resources/fabric.mod.json b/src/main/resources/fabric.mod.json index b01b8ea..16c33eb 100644 --- a/src/main/resources/fabric.mod.json +++ b/src/main/resources/fabric.mod.json @@ -9,8 +9,8 @@ "yitzy299" ], "contact": { - "homepage": "https://fabricmc.net/", - "sources": "https://github.com/FabricMC/fabric-example-mod" + "homepage": "https://modrinth.com/project/ledger-databases", + "sources": "https://github.com/QuiltServerTools/Ledger-Databases" }, "license": "LGPL-3.0", From a8844600d36025ee3219a8dd78600150c8762ee6 Mon Sep 17 00:00:00 2001 From: Potatoboy9999 <51728317+PotatoPresident@users.noreply.github.com> Date: Wed, 10 Apr 2024 13:10:06 -0700 Subject: [PATCH 6/6] Fix SQLite and H2 file paths --- .../quiltservertools/ledger/databases/databases/H2Database.kt | 2 +- .../net/quiltservertools/ledger/databases/databases/SQLite.kt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/kotlin/net/quiltservertools/ledger/databases/databases/H2Database.kt b/src/main/kotlin/net/quiltservertools/ledger/databases/databases/H2Database.kt index b8a06d3..ffd0b84 100644 --- a/src/main/kotlin/net/quiltservertools/ledger/databases/databases/H2Database.kt +++ b/src/main/kotlin/net/quiltservertools/ledger/databases/databases/H2Database.kt @@ -8,7 +8,7 @@ import kotlin.io.path.pathString object H2Database : LedgerDatabase { override fun getDataSource(savePath: Path): DataSource = JdbcDataSource().apply { - setURL("jdbc:h2:${savePath.pathString};MODE=MySQL") + setURL("jdbc:h2:${savePath.resolve("ledger.h2").pathString};MODE=MySQL") } override fun getDatabaseIdentifier() = LedgerDatabases.identifier("h2") diff --git a/src/main/kotlin/net/quiltservertools/ledger/databases/databases/SQLite.kt b/src/main/kotlin/net/quiltservertools/ledger/databases/databases/SQLite.kt index 5458767..89866d3 100644 --- a/src/main/kotlin/net/quiltservertools/ledger/databases/databases/SQLite.kt +++ b/src/main/kotlin/net/quiltservertools/ledger/databases/databases/SQLite.kt @@ -7,7 +7,7 @@ import kotlin.io.path.pathString object SQLite : LedgerDatabase { override fun getDataSource(savePath: Path) = SQLiteDataSource().apply { - url = "jdbc:sqlite:${savePath.pathString}" + url = "jdbc:sqlite:${savePath.resolve("ledger.sqlite").pathString}" } override fun getDatabaseIdentifier() = Ledger.identifier(Ledger.DEFAULT_DATABASE)