From 928244ce450fb5cb7a3cced763a904067e48394c Mon Sep 17 00:00:00 2001
From: Brian Cristante <33549821+brcrista@users.noreply.github.com>
Date: Wed, 25 Aug 2021 11:29:50 -0400
Subject: [PATCH 1/3] Add check-dist.yml
---
.github/workflows/check-dist.yml | 51 ++++++++++++++++++++++++++++++++
1 file changed, 51 insertions(+)
create mode 100644 .github/workflows/check-dist.yml
diff --git a/.github/workflows/check-dist.yml b/.github/workflows/check-dist.yml
new file mode 100644
index 00000000..f03f47c4
--- /dev/null
+++ b/.github/workflows/check-dist.yml
@@ -0,0 +1,51 @@
+# `dist/index.js` is a special file in Actions.
+# When you reference an action with `uses:` in a workflow,
+# `index.js` is the code that will run.
+# For our project, we generate this file through a build process from other source files.
+# We need to make sure the checked-in `index.js` actually matches what we expect it to be.
+name: Check dist/
+
+on:
+ push:
+ branches:
+ - main
+ paths-ignore:
+ - '**.md'
+ pull_request:
+ paths-ignore:
+ - '**.md'
+ workflow_dispatch:
+
+jobs:
+ check-dist:
+ runs-on: ubuntu-latest
+
+ steps:
+ - uses: actions/checkout@v2
+
+ - name: Set Node.js 12.x
+ uses: actions/setup-node@v1
+ with:
+ node-version: 12.x
+
+ - name: Install dependencies
+ run: npm ci
+
+ - name: Rebuild the dist/ directory
+ run: npm run build
+
+ - name: Compare the expected and actual dist/ directories
+ run: |
+ if [ "$(git diff --ignore-space-at-eol dist/ | wc -l)" -gt "0" ]; then
+ echo "Detected uncommitted changes after build. See status below:"
+ git diff
+ exit 1
+ fi
+ id: diff
+
+ # If index.js was different than expected, upload the expected version as an artifact
+ - uses: actions/upload-artifact@v2
+ if: ${{ failure() && steps.diff.conclusion == 'failure' }}
+ with:
+ name: dist
+ path: dist/
From 85d412253086d787de7add5f46dcf5964224c032 Mon Sep 17 00:00:00 2001
From: Brian Cristante <33549821+brcrista@users.noreply.github.com>
Date: Wed, 25 Aug 2021 11:29:51 -0400
Subject: [PATCH 2/3] Fix triggers in licensed.yml
---
.github/workflows/licensed.yml | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/.github/workflows/licensed.yml b/.github/workflows/licensed.yml
index ae62613f..4c1dfe5f 100644
--- a/.github/workflows/licensed.yml
+++ b/.github/workflows/licensed.yml
@@ -1,8 +1,12 @@
name: Licensed
on:
- push: {branches: main}
- pull_request: {branches: main}
+ push:
+ branches:
+ - main
+ pull_request:
+ branches:
+ - main
jobs:
test:
@@ -17,4 +21,4 @@ jobs:
curl -Lfs -o licensed.tar.gz https://github.com/github/licensed/releases/download/2.12.2/licensed-2.12.2-linux-x64.tar.gz
sudo tar -xzf licensed.tar.gz
sudo mv licensed /usr/local/bin/licensed
- - run: licensed status
\ No newline at end of file
+ - run: licensed status
From 996306e892eb8e97c8cfe8226ee043ae86a8f377 Mon Sep 17 00:00:00 2001
From: Brian Cristante <33549821+brcrista@users.noreply.github.com>
Date: Thu, 16 Sep 2021 10:54:26 -0400
Subject: [PATCH 3/3] rm __tests__/verify-no-unstaged-changes.sh
---
.github/workflows/build-test.yml | 5 +----
__tests__/verify-no-unstaged-changes.sh | 17 -----------------
2 files changed, 1 insertion(+), 21 deletions(-)
delete mode 100755 __tests__/verify-no-unstaged-changes.sh
diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml
index da4c182e..9a3aa93b 100644
--- a/.github/workflows/build-test.yml
+++ b/.github/workflows/build-test.yml
@@ -26,7 +26,4 @@ jobs:
- run: npm ci
- run: npm run build
- run: npm run format-check
- - run: npm test
- - name: Verify no unstaged changes
- if: runner.os != 'windows'
- run: __tests__/verify-no-unstaged-changes.sh
+ - run: npm test
\ No newline at end of file
diff --git a/__tests__/verify-no-unstaged-changes.sh b/__tests__/verify-no-unstaged-changes.sh
deleted file mode 100755
index f3260e3b..00000000
--- a/__tests__/verify-no-unstaged-changes.sh
+++ /dev/null
@@ -1,17 +0,0 @@
-#!/bin/bash
-
-if [[ "$(git status --porcelain)" != "" ]]; then
- echo ----------------------------------------
- echo git status
- echo ----------------------------------------
- git status
- echo ----------------------------------------
- echo git diff
- echo ----------------------------------------
- git diff
- echo ----------------------------------------
- echo Troubleshooting
- echo ----------------------------------------
- echo "::error::Unstaged changes detected. Locally try running: git clean -ffdx && npm ci && npm run pre-checkin"
- exit 1
-fi